[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <86h8umasg1.fsf@arm.com>
Date: Thu, 26 Oct 2017 15:34:38 +0100
From: Marc Zyngier <marc.zyngier@....com>
To: Paolo Bonzini <pbonzini@...hat.com>
Cc: linux-kernel@...r.kernel.org, kvm@...r.kernel.org, Christoffer Dall
<christoffer.dall@...aro.org>, Christian Borntraeger
<borntraeger@...ibm.com>, Cornelia Huck <cohuck@...hat.com>, James Hogan
<james.hogan@...tec.com>, Paul Mackerras <paulus@...ba.org>,
kernel-hardening@...ts.openwall.com, Kees Cook <keescook@...omium.org>,
Christian Borntraeger <borntraeger@...hat.com>, Christoffer Dall
<cdall@...aro.org>, Radim Krčmář <rkrcmar@...hat.com>
Subject: Re: [PATCH 1/2] kvm: whitelist struct kvm_vcpu_arch
On Thu, Oct 26 2017 at 3:45:46 pm BST, Paolo Bonzini <pbonzini@...hat.com> wrote:
> On x86, ARM and s390, struct kvm_vcpu_arch has a usercopy region
> taht is read and written by the KVM_GET/SET_CPUID2 ioctls (x86)
> or KVM_GET/SET_ONE_REG (ARM/s390). Without whitelisting the area,
> KVM is completely broken on those architectures with usercopy hardening
> enabled.
>
> For now, allow writing to the entire struct on all architectures.
> The KVM tree will not refine this to an architecture-specific
> subset of struct kvm_vcpu_arch.
>
> Cc: kernel-hardening@...ts.openwall.com
> Cc: Kees Cook <keescook@...omium.org>
> Cc: Christian Borntraeger <borntraeger@...hat.com>
> Cc: Christoffer Dall <cdall@...aro.org>
> Cc: Radim Krčmář <rkrcmar@...hat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@...hat.com>
Acked-by: Marc Zyngier <marc.zyngier@....com>
M.
--
Jazz is not dead. It just smells funny.
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
