|
Message-ID: <20170907181015.GA9557@infradead.org> Date: Thu, 7 Sep 2017 11:10:15 -0700 From: Christoph Hellwig <hch@...radead.org> To: Tycho Andersen <tycho@...ker.com> Cc: linux-kernel@...r.kernel.org, linux-mm@...ck.org, kernel-hardening@...ts.openwall.com, Marco Benatto <marco.antonio.780@...il.com>, Juerg Haefliger <juerg.haefliger@...onical.com>, Konrad Rzeszutek Wilk <konrad.wilk@...cle.com> Subject: Re: [PATCH v6 04/11] swiotlb: Map the buffer if it was unmapped by XPFO > - if (PageHighMem(pfn_to_page(pfn))) { > + if (PageHighMem(page) || xpfo_page_is_unmapped(page)) { Please don't sprinkle xpfo details over various bits of code. Just add a helper with a descriptive name, e.g. page_is_unmapped() that also includes the highmem case, as that will easily document what this check is doing.
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.