|
Message-ID: <CAGXu5jKsZP-zc4zFMzysmnyw--Dh=4JxVWdsw+djChzENS2K_Q@mail.gmail.com> Date: Thu, 17 Aug 2017 08:08:38 -0700 From: Kees Cook <keescook@...gle.com> To: Christoph Hellwig <hch@...radead.org> Cc: Thomas Gleixner <tglx@...utronix.de>, LKML <linux-kernel@...r.kernel.org>, "kernel-hardening@...ts.openwall.com" <kernel-hardening@...ts.openwall.com> Subject: Re: refactoring timers to avoid init_timer*() On Thu, Aug 17, 2017 at 7:40 AM, Christoph Hellwig <hch@...radead.org> wrote: > Instea of bloating the timer even more we should kill off > the data field eventually, which should give you the same > protection. > > See my proposal and the related discussion here: > > http://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1397209.html Ah! Yes, very cool. Most callbacks could be converted to the new timer callback pretty easily. Some, though, pass non-pointer data in the "data" argument. Those can likely be moved to somewhere else, though. I think it should be possible to just perform all the conversions. Regardless, getting rid of init_timer*() and eliminating the open-coded callback assignments should help. I'll keep grinding on that. -Kees -- Kees Cook Pixel Security
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.