Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20170803144926.7eankdjmnyxw3zru@armageddon.cambridge.arm.com>
Date: Thu, 3 Aug 2017 15:49:27 +0100
From: Catalin Marinas <catalin.marinas@....com>
To: Mark Rutland <mark.rutland@....com>
Cc: linux-arm-kernel@...ts.infradead.org, linux-arch@...r.kernel.org,
	arnd@...db.de, jiong.wang@....com, marc.zyngier@....com,
	yao.qi@....com, suzuki.poulose@....com, will.deacon@....com,
	linux-kernel@...r.kernel.org, Dave.Martin@....com,
	kernel-hardening@...ts.openwall.com, kvmarm@...ts.cs.columbia.edu,
	christoffer.dall@...aro.org
Subject: Re: [PATCH 01/11] arm64: docs: describe ELF hwcaps

On Wed, Jul 19, 2017 at 05:01:22PM +0100, Mark Rutland wrote:
> +3. The hwcaps exposed in AT_HWCAP
> +---------------------------------
> +
> +HWCAP_FP
> +
> +    Functionality implied by ID_AA64PFR0_EL1.FP == 0b0000.

Aren't these too restrictive? Linux would still present HWCAP_FP even
when ID_AA64PFR0_EL1.FP == 1. I think we should replace the strict
equal with greater than or equal, also mentioning that the field is
signed (or refer to the cpuid where the sign of the fields is
described).

-- 
Catalin

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.