Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAGXu5j+OnEHFsOLVXpw5F0igkwR8UJQF4tS99J3Vhza3sN_zjg@mail.gmail.com>
Date: Tue, 25 Jul 2017 13:16:58 -0700
From: Kees Cook <keescook@...omium.org>
To: "Valdis.Kletnieks@...edu" <valdis.kletnieks@...edu>
Cc: "kernel-hardening@...ts.openwall.com" <kernel-hardening@...ts.openwall.com>
Subject: Re: Issue with CONFIG_GCC_PLUGIN_RANDSTRUCT=y and
 out of tree modules..

On Mon, Jul 24, 2017 at 8:21 PM,  <valdis.kletnieks@...edu> wrote:
> I discovered the hard way that changing that config variable from n to y
> and then doing a 'make' of an out of tree module resulted in it not working.

Hm, I'd need to know more details, but normally switching out the gcc
plugin config should trigger a full rebuild.

> Once I did a 'make clean', the next 'make' resulted in a working module.
> So I'm guessing that the kernel dependencies were too subtle for
> the 'make' to notice that the structures had changed logically, if not
> source code wise.  Probably not fixable, but could probably use
> a line or two in the Kconfig help for the item.
>
> I'll code a patch if that seems like a good idea...

Yeah, "make clean" would fix it. If you see a solution for what you
saw, yeah, send a patch. :)

Thanks!

-Kees

-- 
Kees Cook
Pixel Security

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.