|
Message-ID: <fb9f92d2-6737-d9ae-ed49-fa61a089c727@linux.com> Date: Wed, 12 Jul 2017 09:01:04 +0300 From: Alexander Popov <alex.popov@...ux.com> To: Mark Rutland <mark.rutland@....com>, Laura Abbott <labbott@...hat.com> Cc: Kees Cook <keescook@...omium.org>, kernel-hardening@...ts.openwall.com, Ard Biesheuvel <ard.biesheuvel@...aro.org> Subject: Re: [RFC][PATCH 2/2] arm64: Clear the stack Hello Mark, On 11.07.2017 22:51, Mark Rutland wrote: > On Mon, Jul 10, 2017 at 03:04:43PM -0700, Laura Abbott wrote: >> - Where else do we need to clear the stack? > > I guess we might need to clear (all of the remainder of) the stack after > invoking EFI runtime services -- those can run in task context, might > leave sensitive values on the stack, and they're uninstrumented. The > same would apply for x86. Thanks, I've added this to the TODO list. > I think we can ignore garbage left on the stack by idle/hotplug, since > that happens in the idle thread, so we shouldn't be doing uaccess > transfers on those stacks. Excuse me, I didn't understand what you mean. erase_kstack() is called at the end of syscall before returning to the userspace. Best regards, Alexander
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.