[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <871sqlpl63.fsf@concordia.ellerman.id.au>
Date: Thu, 15 Jun 2017 21:03:48 +1000
From: Michael Ellerman <mpe@...erman.id.au>
To: Theodore Ts'o <tytso@....edu>, "Jason A. Donenfeld" <Jason@...c4.com>
Cc: Linux Crypto Mailing List <linux-crypto@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>, kernel-hardening@...ts.openwall.com, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, David Miller <davem@...emloft.net>, Eric Biggers <ebiggers3@...il.com>
Subject: Re: Re: [PATCH v4 13/13] random: warn when kernel uses unseeded randomness
Theodore Ts'o <tytso@....edu> writes:
> On Tue, Jun 06, 2017 at 07:48:04PM +0200, Jason A. Donenfeld wrote:
>> This enables an important dmesg notification about when drivers have
>> used the crng without it being seeded first. Prior, these errors would
>> occur silently, and so there hasn't been a great way of diagnosing these
>> types of bugs for obscure setups. By adding this as a config option, we
>> can leave it on by default, so that we learn where these issues happen,
>> in the field, will still allowing some people to turn it off, if they
>> really know what they're doing and do not want the log entries.
...
>
> This patch is pretty spammy. On my KVM test kernel:
>
> random: bucket_table_alloc+0x15f/0x190 get_random_u32 called with crng_init = 0
> random: bucket_table_alloc+0x15f/0x190 get_random_u32 called with crng_init = 0
> random: bucket_table_alloc+0x15f/0x190 get_random_u32 called with crng_init = 0
> random: bucket_table_alloc+0x15f/0x190 get_random_u32 called with crng_init = 0
...
>
> At the very least we probably should do a logical "uniq" on the output
> (e.g., if we have complained about the previous callsite, don't whinge
> about it again).
>
> commit 9d9035bc6d7871a73d7f9aada4e63cb190874a68
> Author: Theodore Ts'o <tytso@....edu>
> Date: Thu Jun 8 04:16:59 2017 -0400
>
> random: suppress duplicate crng_init=0 warnings
>
> Suppress duplicate CONFIG_WARN_UNSEEDED_RANDOM warnings to avoid
> spamming dmesg.
>
> Signed-off-by: Theodore Ts'o <tytso@....edu>
Even with this patch, it's still pretty spammy (today's linux-next):
random: load_elf_binary+0x57c/0x1550 get_random_u64 called with crng_init=0
random: arch_randomize_brk+0xa4/0xd0 get_random_u64 called with crng_init=0
random: arch_mmap_rnd+0x78/0xb0 get_random_u64 called with crng_init=0
random: load_elf_binary+0x57c/0x1550 get_random_u64 called with crng_init=0
random: arch_randomize_brk+0xa4/0xd0 get_random_u64 called with crng_init=0
random: arch_mmap_rnd+0x78/0xb0 get_random_u64 called with crng_init=0
random: load_elf_binary+0x57c/0x1550 get_random_u64 called with crng_init=0
random: arch_randomize_brk+0xa4/0xd0 get_random_u64 called with crng_init=0
random: arch_mmap_rnd+0x78/0xb0 get_random_u64 called with crng_init=0
random: load_elf_binary+0x57c/0x1550 get_random_u64 called with crng_init=0
random: arch_randomize_brk+0xa4/0xd0 get_random_u64 called with crng_init=0
random: arch_mmap_rnd+0x78/0xb0 get_random_u64 called with crng_init=0
random: load_elf_binary+0x57c/0x1550 get_random_u64 called with crng_init=0
random: arch_mmap_rnd+0x78/0xb0 get_random_u64 called with crng_init=0
random: load_elf_binary+0x57c/0x1550 get_random_u64 called with crng_init=0
random: arch_randomize_brk+0xa4/0xd0 get_random_u64 called with crng_init=0
Initializing random number generator... random: arch_mmap_rnd+0x78/0xb0 get_random_u64 called with crng_init=0
random: load_elf_binary+0x57c/0x1550 get_random_u64 called with crng_init=0
random: arch_randomize_brk+0xa4/0xd0 get_random_u64 called with crng_init=0
random: arch_mmap_rnd+0x78/0xb0 get_random_u64 called with crng_init=0
random: load_elf_binary+0x57c/0x1550 get_random_u64 called with crng_init=0
random: arch_randomize_brk+0xa4/0xd0 get_random_u64 called with crng_init=0
random: arch_mmap_rnd+0x78/0xb0 get_random_u64 called with crng_init=0
random: load_elf_binary+0x57c/0x1550 get_random_u64 called with crng_init=0
random: arch_randomize_brk+0xa4/0xd0 get_random_u64 called with crng_init=0
Do I need to be doing anything to fix these? (this is on powerpc)
cheers
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
