[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <c3ae85ab-539f-daa1-e318-3175b674d4a2@gmail.com>
Date: Fri, 9 Jun 2017 14:00:37 +0200
From: HacKurx <hackurx@...il.com>
To: Anisse Astier <anisse@...ier.eu>
Cc: Kees Cook <keescook@...omium.org>, Rik van Riel <riel@...hat.com>,
intrigeri <intrigeri@...m.org>,
"kernel-hardening@...ts.openwall.com" <kernel-hardening@...ts.openwall.com>
Subject: Re: Patch for random mac address
Le 26/05/2017 à 14:34, Anisse Astier a écrit :
> On Fri, May 26, 2017 at 09:55:37AM +0200, HacKurx wrote:
>> diff --git a/net/core/dev.c b/net/core/dev.c
>> index fca407b..3eeb42b 100644
>> --- a/net/core/dev.c
>> +++ b/net/core/dev.c
>> @@ -6669,6 +6669,26 @@ int dev_change_flags(struct net_device *dev, unsigned int flags)
>>
>> changes = (old_flags ^ dev->flags) | (old_gflags ^ dev->gflags);
>> __dev_notify_flags(dev, old_flags, changes);
>> +
>> +#ifdef CONFIG_RANDOM_MAC_ADDRESS
>> + if ((changes & IFF_UP) && !(old_flags & IFF_UP)) {
>> + /* randomize MAC whenever interface is brought up */
>> + struct sockaddr sa;
>> + unsigned int mac4;
>> + unsigned short mac2;
>> +
>> + mac4 = prandom_u32();
>> + mac2 = prandom_u32();
>> + memcpy(sa.sa_data, &mac4, sizeof(mac4));
>> + memcpy((char *)sa.sa_data + sizeof(mac4), &mac2, sizeof(mac2));
>> + if (!is_valid_ether_addr(sa.sa_data))
>> + sa.sa_data[5] = 1;
>> + sa.sa_data[0] &= 0xFC;
>> + sa.sa_family = dev->type;
>> + dev_set_mac_address(dev, &sa);
> You didn't answer my question regarding why this is different from the
> function eth_random_addr.
What do you think by replacing the whole by that?
+#ifdef CONFIG_RANDOM_MAC_ADDRESS
+ /* randomize MAC whenever interface is brought up */
+ if ((changes & IFF_UP) && !(old_flags & IFF_UP)) {
+ struct sockaddr sa;
+ eth_random_addr(sa.sa_data);
+ sa.sa_family = dev->type;
+ dev_set_mac_address(dev, &sa);
The network doesn't work with "eth_hw_addr_random(dev);" (the change of MAC addresses works well). Do you know why ?
Because the eth_hw_addr_randomfunction works better on all types of network cards.
Thanks,
Loic
Content of type "text/html" skipped
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
