Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 6 Jun 2017 14:23:09 +0200
From: "Jason A. Donenfeld" <>
To: David Howells <>
Cc: "Theodore Ts'o" <>, Linux Crypto Mailing List <>, 
	LKML <>,, 
	Greg Kroah-Hartman <>, David Miller <>, 
	Mimi Zohar <>, David Safford <>
Subject: Re: [PATCH v3 05/13] security/keys: ensure RNG is seeded before use

On Tue, Jun 6, 2017 at 12:08 PM, David Howells <> wrote:
> Jason A. Donenfeld <> wrote:
>> +             key->serial = get_random_u32() >> 1;
> If this may sleep, it must be interruptible.

That won't sleep. I could have made it get_random_u32_wait(), but we'd
get into trouble at boottime. So instead, for now, I just use
get_random_u32 rather than get_random_bytes, which can use the
architectural random number generator, when the platform has one,
which is available early on.

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.