[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAGXu5jKYHVWUnLpMn4Ef9S=0hCX-hh0h_UGuV7+a_jz5v68mFQ@mail.gmail.com>
Date: Sun, 28 May 2017 10:37:26 -0700
From: Kees Cook <keescook@...omium.org>
To: Christoph Hellwig <hch@...radead.org>, Linux-MM <linux-mm@...ck.org>,
Network Development <netdev@...r.kernel.org>
Cc: "kernel-hardening@...ts.openwall.com" <kernel-hardening@...ts.openwall.com>,
"David S . Miller" <davem@...emloft.net>, Laura Abbott <labbott@...hat.com>,
"x86@...nel.org" <x86@...nel.org>, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 08/20] randstruct: Whitelist NIU struct page overloading
[trying again with correct linux-mm address...]
On Sun, May 28, 2017 at 1:15 AM, Christoph Hellwig <hch@...radead.org> wrote:
> On Fri, May 26, 2017 at 01:17:12PM -0700, Kees Cook wrote:
>> The NIU ethernet driver intentionally stores a page struct pointer on
>> top of the "mapping" field. Whitelist this case:
>>
>> drivers/net/ethernet/sun/niu.c: In function ‘niu_rx_pkt_ignore’:
>> drivers/net/ethernet/sun/niu.c:3402:10: note: found mismatched ssa struct pointer types: ‘struct page’ and ‘struct address_space’
>>
>> *link = (struct page *) page->mapping;
>> ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>
>> Cc: David S. Miller <davem@...emloft.net>
>> Signed-off-by: Kees Cook <keescook@...omium.org>
>
> The driver really needs to stop doing this anyway. It would be good
> to send this out to linux-mm and netdev to come up with a better scheme.
Added to To. :) I couldn't understand why it was doing what it was
doing, hence the whitelist entry.
-Kees
--
Kees Cook
Pixel Security
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
