[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20170527084414.GC26844@infradead.org>
Date: Sat, 27 May 2017 01:44:14 -0700
From: Christoph Hellwig <hch@...radead.org>
To: Kees Cook <keescook@...omium.org>
Cc: kernel-hardening@...ts.openwall.com, Laura Abbott <labbott@...hat.com>,
x86@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 12/20] sgi-xp: Use designated initializers
On Fri, May 26, 2017 at 01:17:16PM -0700, Kees Cook wrote:
> Prepare to mark sensitive kernel structures for randomization by making
> sure they're using designated initializers. These were identified during
> allyesconfig builds of x86, arm, and arm64, with most initializer fixes
> extracted from grsecurity.
>
> To avoid casting, this implements dummy functions with full function
> prototypes.
Can we get this in ASAP?
> +static void xpc_notloaded_connect(int ch_number)
> +{ }
> +
> +static void xpc_notloaded_disconnect(int ch_number)
> +{ }
Also it might be a good idea to just check in the caller if the
methods are defined instead of having all these dummys. A branch
is usually cheaper than an indirect call, AND it leads to less code,
AND is is less fragile.
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
