[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAFwXZv_Nb5Q8n1kobbxz7+3w4r6pt-fD5YR4jw6_ZeXk1__9+A@mail.gmail.com>
Date: Fri, 26 May 2017 09:55:37 +0200
From: HacKurx <hackurx@...il.com>
To: Kees Cook <keescook@...omium.org>
Cc: Rik van Riel <riel@...hat.com>, intrigeri <intrigeri@...m.org>,
"kernel-hardening@...ts.openwall.com" <kernel-hardening@...ts.openwall.com>
Subject: Re: Patch for random mac address
2017-05-25 19:28 GMT+02:00 Kees Cook <keescook@...omium.org>:
> On Thu, May 25, 2017 at 8:59 AM, Rik van Riel <riel@...hat.com> wrote:
>> On Thu, 2017-05-25 at 17:47 +0200, intrigeri wrote:
>>> Rik van Riel:
>>> > That suggests maybe this kind of functionality should
>>> > be implemented in userspace, instead?
>>> > Maybe in NetworkManager, […]
>>>
>>> It's already implemented in NetworkManager :)
>>
>> So this kernel patch does not solve any problem,
>> because the solution has already been implemented
>> in userspace?
>
> It makes sure you can never not randomize the MAC
You have perfectly understood.
> BTW, the proposed patch is slightly wrong: it still allows userspace
> to change the MAC address.
This is not the most important because it is already another MAC
address because this patch randomize MAC whenever interface is brought
up.
> The ifdef with the return 0 should be moved
> up (and "return 0" seems like a bit of a lie: maybe -EINVAL or
> -ENOTSUPPORTED?).
-EINVAL seems to be a good idea, I will use it to never reveal the
permanent MAC address.
> How about sending a v2 with that fixed, inline, etc.
Agree with the V2. I'm not a developer, what do you mean by inline? Send by GIT?
If someone can make him grow in my place I will pay him a beer ^^
Thank you all. Best regards,
HacKurx (Loic)
View attachment "random-mac_linux-4.12-rc2_v2.diff" of type "text/plain" (1934 bytes)
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
