kernel-hardening - Re: Patch for random mac address

Follow @Openwall on Twitter for new release announcements and other news

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABob6iruHWvNfjGh1ofMxC3Jg_XBGxmBCTfiaVaBMrA33FgoCQ@mail.gmail.com>
Date: Thu, 25 May 2017 01:05:29 +0200
From: Lukas Odzioba <lukas.odzioba@...il.com>
To: Casey Schaufler <casey@...aufler-ca.com>
Cc: HacKurx <hackurx@...il.com>, kernel-hardening@...ts.openwall.com, 
	keescook@...gle.com
Subject: Re: Patch for random mac address

2017-05-25 0:40 GMT+02:00 Casey Schaufler <casey@...aufler-ca.com>:
>
> @@ -262,6 +262,10 @@ static int dev_ifsioc(struct net *net, struct ifreq *ifr, unsigned int cmd)
>
>  case SIOCSIFHWADDR:
>  return dev_set_mac_address(dev, &ifr->ifr_hwaddr);
> +#ifdef CONFIG_RANDOM_MAC_ADDRESS
> + /* ignore userland MAC changes */
> + return 0;
> +#endif

I am not sure whether this code does what the comment advertises, but
I bet that Kali-like distro users still would like to be able to
change MAC, also such behavior should be documented in config section.
Thank you for your involvement, please take a look at this article
about preparing kernel patches in general (besides ml addresses most
of it could apply here as well):
https://www.kernel.org/doc/html/latest/process/submitting-patches.html

Thanks,
Lukas

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.