[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20170506050022.GA11385@kroah.com>
Date: Fri, 5 May 2017 22:00:22 -0700
From: Greg KH <gregkh@...uxfoundation.org>
To: Joe Perches <joe@...ches.com>
Cc: kernel-hardening@...ts.openwall.com, Petr Mladek <pmladek@...e.com>,
Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
linux-kernel@...r.kernel.org,
Catalin Marinas <catalin.marinas@....com>,
Will Deacon <will.deacon@....com>,
Steven Rostedt <rostedt@...dmis.org>,
William Roberts <william.c.roberts@...el.com>,
Chris Fries <cfries@...gle.com>, Dave Weinstein <olorin@...gle.com>
Subject: Re: [RFC 5/6] lib: vsprintf: Add "%paP", "%padP" options
On Fri, May 05, 2017 at 09:42:40PM -0700, Joe Perches wrote:
> On Fri, 2017-05-05 at 21:07 -0700, Greg KH wrote:
> > From: Chris Fries <cfries@...gle.com>
> >
> > Add %paP and %padP for physical address that need to always be shown
> > regardless of kptr restrictions.
>
> The commit message could be improved.
Good point, I'll work on that, thanks.
> I had to look at the actual code to see if %papP was supported.
>
> > diff --git a/Documentation/printk-formats.txt b/Documentation/printk-formats.txt
> []
> > @@ -82,18 +82,20 @@ Struct Resources:
> >
> > Physical addresses types phys_addr_t:
> >
> > - %pa[p] 0x01234567 or 0x0123456789abcdef
> > + %pa[p][P] 0x01234567 or 0x0123456789abcdef
>
> Well, that's good.
>
> > diff --git a/lib/vsprintf.c b/lib/vsprintf.c
> []
> > @@ -1394,23 +1394,29 @@ static noinline_for_stack
> > char *address_val(char *buf, char *end, const void *addr, const char *fmt)
> > {
> > unsigned long long num;
> > + int cleanse = kptr_restrict_cleanse_addresses();
>
> bool
I'll change this, thanks.
greg k-h
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
