[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <d7dc3242-210b-37c1-3b6e-9e48c17fb3a9@nmatt.com>
Date: Tue, 18 Apr 2017 00:29:19 -0400
From: Matt Brown <matt@...tt.com>
To: Greg KH <gregkh@...uxfoundation.org>
Cc: jmorris@...ei.org, akpm@...ux-foundation.org,
linux-security-module@...r.kernel.org, linux-kernel@...r.kernel.org,
kernel-hardening@...ts.openwall.com
Subject: Re: [PATCH 1/4] added SECURITY_TIOCSTI_RESTRICT kernel config
On 04/17/2017 02:50 AM, Greg KH wrote:
> On Mon, Apr 17, 2017 at 02:07:03AM -0400, Matt Brown wrote:
>> adding the kernel config SECURITY_TIOCSTI_RESTRICT in order to allow
>> the user to restrict unprivileged command injection using TIOCSTI
>> tty ioctls
>
> "unpriviledged command injection"? That sounds a bit "odd", don't you
> think?
>
>>
>> Signed-off-by: Matt Brown <matt@...tt.com>
>> ---
>> security/Kconfig | 12 ++++++++++++
>> 1 file changed, 12 insertions(+)
>>
>> diff --git a/security/Kconfig b/security/Kconfig
>> index 3ff1bf9..d757bcb 100644
>> --- a/security/Kconfig
>> +++ b/security/Kconfig
>> @@ -18,6 +18,18 @@ config SECURITY_DMESG_RESTRICT
>>
>> If you are unsure how to answer this question, answer N.
>>
>> +config SECURITY_TIOCSTI_RESTRICT
>> + bool "Restrict unprivileged use of tiocsti command injection"
>> + default n
>> + help
>> + This enforces restrictions on unprivileged users injecting commands
>> + into other processes in the same tty session using the TIOCSTI ioctl
>
> Tabs and spaces?
>
Sorry about that. Used the wrong vimrc for part of the Kconfig. Will
fix in updated patch.
> Since tty sessions are usually separated by different users, how would
> they have the same one and yet need something like this?
>
> Also, why not put this in the tty config section?
>
> And finally, this patch on its own doesn't do anything :(
>
I will take your input, update my code, and resubmit as a single
patch.
> thanks,
>
> greg k-h
>
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
