|
Message-ID: <CAGXu5j+EAXaSHL_6r65OcaMS687ijxmiJaYhYG66-HrJi6uuVg@mail.gmail.com> Date: Wed, 1 Mar 2017 12:31:24 -0800 From: Kees Cook <keescook@...omium.org> To: Mark Rutland <mark.rutland@....com> Cc: Hoeun Ryu <hoeun.ryu@...il.com>, "kernel-hardening@...ts.openwall.com" <kernel-hardening@...ts.openwall.com>, Andy Lutomirski <luto@...nel.org>, PaX Team <pageexec@...email.hu>, Emese Revfy <re.emese@...il.com>, Russell King <linux@...linux.org.uk>, "x86@...nel.org" <x86@...nel.org> Subject: Re: [RFC][PATCH 1/8] Introduce rare_write() infrastructure On Wed, Mar 1, 2017 at 12:13 PM, Kees Cook <keescook@...omium.org> wrote: > Here's some sed output: http://paste.ubuntu.com/24092015/ > > grsecurity currently has 314 instances of using > pax_open/close_kernel(). The number of lines of code between them is > about half a single line, but there is a lot of variation on how it's > used: > > count lines-of-code > 164 1 > 72 2 > 21 3 > 20 4 > 2 5 > 8 6 > 3 7 > 2 8 > 1 9 > 18 10+ Oops, bug in grsecurity fooled my scripts and evaded detection. There's another 3 line use. If you search the pastebin for pax_open_kernel, you can see a giant bit in the middle that isn't supposed to be there: drivers/pci/hotplug/cpcihp_zt5550.c pax_open_kernel(); const_cast(zt5550_hpc_ops.enable_irq) = zt5550_hc_enable_irq; const_cast(zt5550_hpc_ops.disable_irq) = zt5550_hc_disable_irq; const_cast(zt5550_hpc_ops.check_irq) = zt5550_hc_check_irq; pax_open_kernel(); I'll send a patch... -Kees -- Kees Cook Pixel Security
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.