kernel-hardening - Re: [PATCH v2 2/5] time: mark syscore_ops as __ro_after

Follow @Openwall on Twitter for new release announcements and other news

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.20.1702111016120.3734@nanos>
Date: Sat, 11 Feb 2017 10:23:16 +0100 (CET)
From: Thomas Gleixner <tglx@...utronix.de>
To: John Stultz <john.stultz@...aro.org>
cc: Jess Frazelle <me@...sfraz.com>, Rik van Riel <riel@...hat.com>, 
    open list <linux-kernel@...r.kernel.org>, 
    kernel-hardening@...ts.openwall.com
Subject: Re: [PATCH v2 2/5] time: mark syscore_ops as __ro_after_init

On Fri, 10 Feb 2017, John Stultz wrote:

> On Fri, Feb 10, 2017 at 5:37 PM, Jess Frazelle <me@...sfraz.com> wrote:
> > Marked syscore_ops structs as __ro_after_init when register_syscore_ops was
> > called only during init. Most of the caller functions were already annotated as
> > __init.
> > unregister_syscore_ops() was never called on these ops.
> > This protects the data structure from accidental corruption.
> >
> > Suggested-by: Kees Cook <keescook@...omium.org>
> > Signed-off-by: Jess Frazelle <me@...sfraz.com>
> > Acked-by: Rik van Riel <riel@...hat.com>
> 
> Thanks for sending this out. Looks reasonable to me. I'll queue it for
> testing, targeting for 4.12.

NAK. See:

  http://lkml.kernel.org/r/alpine.DEB.2.20.1702110948030.3734@nanos

Thanks,

	tglx

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.