kernel-hardening - Re: [PATCH v2 1/1] powerpc: mm: support ARCH_MMAP_RND

Follow @Openwall on Twitter for new release announcements and other news

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87efzag2fs.fsf@concordia.ellerman.id.au>
Date: Tue, 07 Feb 2017 13:27:51 +1100
From: Michael Ellerman <mpe@...erman.id.au>
To: Bhupesh Sharma <bhsharma@...hat.com>, linuxppc-dev@...ts.ozlabs.org, kernel-hardening@...ts.openwall.com
Cc: dcashman@...gle.com, bhupesh.linux@...il.com, keescook@...omium.org, Bhupesh Sharma <bhsharma@...hat.com>, Alexander Graf <agraf@...e.com>, Benjamin Herrenschmidt <benh@...nel.crashing.org>, Paul Mackerras <paulus@...ba.org>, Anatolij Gustschin <agust@...x.de>, Alistair Popple <alistair@...ple.id.au>, Matt Porter <mporter@...nel.crashing.org>, Vitaly Bordug <vitb@...nel.crashing.org>, Scott Wood <oss@...error.net>, Kumar Gala <galak@...nel.crashing.org>, Daniel Cashman <dcashman@...roid.com>
Subject: Re: [PATCH v2 1/1] powerpc: mm: support ARCH_MMAP_RND_BITS

Bhupesh Sharma <bhsharma@...hat.com> writes:

> powerpc: arch_mmap_rnd() uses hard-coded values, (23-PAGE_SHIFT) for
> 32-bit and (30-PAGE_SHIFT) for 64-bit, to generate the random offset
> for the mmap base address.
>
> This value represents a compromise between increased
> ASLR effectiveness and avoiding address-space fragmentation.
> Replace it with a Kconfig option, which is sensibly bounded, so that
> platform developers may choose where to place this compromise.
> Keep default values as new minimums.
>
> This patch makes sure that now powerpc mmap arch_mmap_rnd() approach
> is similar to other ARCHs like x86, arm64 and arm.
>
> Cc: Alexander Graf <agraf@...e.com>
> Cc: Benjamin Herrenschmidt <benh@...nel.crashing.org>
> Cc: Paul Mackerras <paulus@...ba.org>
> Cc: Michael Ellerman <mpe@...erman.id.au>
> Cc: Anatolij Gustschin <agust@...x.de>
> Cc: Alistair Popple <alistair@...ple.id.au>
> Cc: Matt Porter <mporter@...nel.crashing.org>
> Cc: Vitaly Bordug <vitb@...nel.crashing.org>
> Cc: Scott Wood <oss@...error.net>
> Cc: Kumar Gala <galak@...nel.crashing.org>
> Cc: Daniel Cashman <dcashman@...roid.com>
> Signed-off-by: Bhupesh Sharma <bhsharma@...hat.com>
> Reviewed-by: Kees Cook <keescook at chromium.org>
> ---
> Changes since v1:
> v1 can be seen here (https://lists.ozlabs.org/pipermail/linuxppc-dev/2017-February/153594.html)
>     - No functional change in this patch.
>     - Added R-B from Kees.
>     - Dropped PATCH 2/2 from v1 as recommended by Kees Cook.

Thanks for v2.

But I replied to your v1 with some comments, did you see them?

cheers

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.