|
Message-ID: <CAHmME9oWDHs2DCRFc8WmvScrj0-cz9EKUHFeiRNTanXLe-v2Sw@mail.gmail.com> Date: Fri, 16 Dec 2016 21:39:54 +0100 From: "Jason A. Donenfeld" <Jason@...c4.com> To: Jean-Philippe Aumasson <jeanphilippe.aumasson@...il.com> Cc: George Spelvin <linux@...encehorizons.net>, Andi Kleen <ak@...ux.intel.com>, David Miller <davem@...emloft.net>, David Laight <David.Laight@...lab.com>, Eric Biggers <ebiggers3@...il.com>, Hannes Frederic Sowa <hannes@...essinduktion.org>, kernel-hardening@...ts.openwall.com, Linux Crypto Mailing List <linux-crypto@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>, Andy Lutomirski <luto@...capital.net>, Netdev <netdev@...r.kernel.org>, Tom Herbert <tom@...bertland.com>, Linus Torvalds <torvalds@...ux-foundation.org>, "Theodore Ts'o" <tytso@....edu>, Vegard Nossum <vegard.nossum@...il.com>, "Daniel J . Bernstein" <djb@...yp.to> Subject: Re: [PATCH v5 1/4] siphash: add cryptographically secure PRF Hi JP, On Fri, Dec 16, 2016 at 2:22 PM, Jean-Philippe Aumasson <jeanphilippe.aumasson@...il.com> wrote: > It needs some basic security review, which I'll try do next week (check for > security margin, optimality of rotation counts, etc.). But after a lot of > experience with this kind of construction (BLAKE, SipHash, NORX), I'm > confident it will be safe as it is. I've implemented it in my siphash kernel branch: https://git.zx2c4.com/linux-dev/log/?h=siphash It's the commit that has "HalfSipHash" in the log message. As the structure is nearly identical to SipHash, there wasn't a lot to change, and so the same implementation strategy exists for each. When you've finished your security review and feel good about it, some test vectors using the same formula (key={0x03020100, 07060504}, input={0x0, 0x1, 0x2, 0x3...}, output=test_vectors) would be nice for verification. Jason
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.