[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <063D6719AE5E284EB5DD2968C1650D6DB023F4DA@AcuExch.aculab.com>
Date: Wed, 14 Dec 2016 09:51:16 +0000
From: David Laight <David.Laight@...LAB.COM>
To: "'Jason A. Donenfeld'" <Jason@...c4.com>, Netdev <netdev@...r.kernel.org>,
David Miller <davem@...emloft.net>, Linus Torvalds
<torvalds@...ux-foundation.org>, "kernel-hardening@...ts.openwall.com"
<kernel-hardening@...ts.openwall.com>, LKML <linux-kernel@...r.kernel.org>,
George Spelvin <linux@...izon.com>, Scott Bauer <sbauer@....utah.edu>, "Andi
Kleen" <ak@...ux.intel.com>, Andy Lutomirski <luto@...capital.net>, Greg KH
<gregkh@...uxfoundation.org>, Eric Biggers <ebiggers3@...il.com>
Subject: RE: [PATCH 3/3] secure_seq: use fast&secure siphash instead of
slow&insecure md5
From: Jason A. Donenfeld
> Sent: 14 December 2016 00:17
> This gives a clear speed and security improvement. Rather than manually
> filling MD5 buffers, we simply create a layout by a simple anonymous
> struct, for which gcc generates rather efficient code.
...
> + const struct {
> + struct in6_addr saddr;
> + struct in6_addr daddr;
> + __be16 sport;
> + __be16 dport;
> + } __packed combined = {
> + .saddr = *(struct in6_addr *)saddr,
> + .daddr = *(struct in6_addr *)daddr,
> + .sport = sport,
> + .dport = dport
> + };
You need to look at the effect of marking this (and the other)
structures 'packed' on architectures like sparc64.
David
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
