[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20161213033942.GC5601@gondor.apana.org.au>
Date: Tue, 13 Dec 2016 11:39:42 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Gary R Hook <ghook@....com>
Cc: Andy Lutomirski <luto@...capital.net>,
Eric Biggers <ebiggers3@...il.com>, linux-crypto@...r.kernel.org,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-mm@...ck.org" <linux-mm@...ck.org>,
"kernel-hardening@...ts.openwall.com" <kernel-hardening@...ts.openwall.com>,
Andrew Lutomirski <luto@...nel.org>,
Stephan Mueller <smueller@...onox.de>
Subject: Re: Remaining crypto API regressions with CONFIG_VMAP_STACK
On Mon, Dec 12, 2016 at 12:45:18PM -0600, Gary R Hook wrote:
> On 12/12/2016 12:34 PM, Andy Lutomirski wrote:
>
> <...snip...>
>
> >
> >I have a patch to make these depend on !VMAP_STACK.
> >
> >> drivers/crypto/ccp/ccp-crypto-aes-cmac.c:105,119,142
> >> drivers/crypto/ccp/ccp-crypto-sha.c:95,109,124
> >> drivers/crypto/ccp/ccp-crypto-aes-xts.c:162
> >> drivers/crypto/ccp/ccp-crypto-aes.c:94
> >
> >According to Herbert, these are fine. I'm personally less convinced
> >since I'm very confused as to what "async" means in the crypto code,
> >but I'm going to leave these alone.
>
> I went back through the code, and AFAICT every argument to sg_init_one() in
> the above-cited files is a buffer that is part of the request context. Which
> is allocated by the crypto framework, and therefore will never be on the
> stack.
> Right?
Right.
Cheers,
--
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
