[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAGXu5j+8=3Vxm52Y2QbkDiCPx5X6DWemPO7B=2kj2EdVQpLHpA@mail.gmail.com>
Date: Tue, 15 Nov 2016 14:41:38 -0800
From: Kees Cook <keescook@...omium.org>
To: Andrew Donnellan <andrew.donnellan@....ibm.com>
Cc: "kernel-hardening@...ts.openwall.com" <kernel-hardening@...ts.openwall.com>, Michal Marek <mmarek@...e.com>,
linux-kbuild <linux-kbuild@...r.kernel.org>, PaX Team <pageexec@...email.hu>,
linuxppc-dev <linuxppc-dev@...ts.ozlabs.org>, Michael Ellerman <mpe@...erman.id.au>
Subject: Re: [PATCH] powerpc/kernel: Disable the latent
entropy plugin unconditionally
On Tue, Nov 1, 2016 at 10:06 PM, Andrew Donnellan
<andrew.donnellan@....ibm.com> wrote:
> On 27/06/16 01:34, Emese Revfy wrote:
>>
>>
>> Reported-by: PaX Team <pageexec@...email.hu>
>> Signed-off-by: Emese Revfy <re.emese@...il.com>
>> ---
>> arch/powerpc/kernel/Makefile | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/powerpc/kernel/Makefile b/arch/powerpc/kernel/Makefile
>> index 01935b8..e9ef44f 100644
>> --- a/arch/powerpc/kernel/Makefile
>> +++ b/arch/powerpc/kernel/Makefile
>> @@ -14,11 +14,12 @@ CFLAGS_prom_init.o += -fPIC
>> CFLAGS_btext.o += -fPIC
>> endif
>>
>> -ifdef CONFIG_FUNCTION_TRACER
>> CFLAGS_cputable.o += $(DISABLE_LATENT_ENTROPY_PLUGIN)
>> CFLAGS_init.o += $(DISABLE_LATENT_ENTROPY_PLUGIN)
>
>
> I think you meant prom_init.o...
>
> Additionally, DISABLE_LATENT_ENTROPY_PLUGIN is conditioned on
> CONFIG_PAX_LATENT_ENTROPY rather than CONFIG_GCC_PLUGIN_LATENT_ENTROPY, so
> it doesn't get exported correctly.
>
> Will submit fixes along with patches to enable plugins on powerpc once I get
> that sorted.
>
> (In future please remember to cc linuxppc-dev.)
Just checking in: did these patches materialize? I'd love to see
plugins working on v4.10 for ppc.
-Kees
--
Kees Cook
Nexus Security
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
