[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2236FBA76BA1254E88B949DDB74E612B41BFAC8B@IRSMSX102.ger.corp.intel.com>
Date: Tue, 1 Nov 2016 10:55:47 +0000
From: "Reshetova, Elena" <elena.reshetova@...el.com>
To: "kernel-hardening@...ts.openwall.com"
<kernel-hardening@...ts.openwall.com>
CC: "keescook@...omium.org" <keescook@...omium.org>, "arnd@...db.de"
<arnd@...db.de>, "tglx@...utronix.de" <tglx@...utronix.de>,
"mingo@...hat.com" <mingo@...hat.com>, "Anvin, H Peter"
<h.peter.anvin@...el.com>, Hans Liljestrand <ishkamiel@...il.com>, "David
Windsor" <dwindsor@...il.com>
Subject: RE: [RFC v3 PATCH 01/13] Add architecture
independent hardened atomic base
<snip>
> arch/alpha/include/asm/local.h | 2 +
> arch/m32r/include/asm/local.h | 2 +
> arch/mips/include/asm/local.h | 2 +
> arch/powerpc/include/asm/local.h | 2 +
> arch/x86/include/asm/local.h | 2 +
<snip>
> include/asm-generic/local.h | 20 +++
> include/asm-generic/local_wrap.h | 89 ++++++++++
<snip>
> diff --git a/include/asm-generic/local.h b/include/asm-generic/local.h
> index 9ceb03b..e1c81c3 100644
> --- a/include/asm-generic/local.h
> +++ b/include/asm-generic/local.h
> @@ -4,6 +4,7 @@
> #include <linux/percpu.h>
> #include <linux/atomic.h>
> #include <asm/types.h>
> +#include <asm-generic/local_wrap.h>
>That brake build for any architecture that uses asm-generic/local.h (like ARM v6/v7): asm-generic/local_wrap.h contains
> typedef local_t local_wrap_t
>but at this time, local_t is not yet defined, since asm- generic/local_wrap.h is included before the definition of local_t. The following patch fixes that.
Oh, yes, we fixed this for all archs. that define local_t by including this header _after_ definition, but asm-generic slipped through.
Will fix right away. Thanks for catching this!
Best Regards,
Elena.
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
