[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <43f1953c-d8a3-647f-20eb-bec4898e1b8e@suse.cz>
Date: Wed, 14 Sep 2016 09:59:42 +0200
From: Jiri Slaby <jslaby@...e.cz>
To: Kees Cook <keescook@...omium.org>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: kernel-hardening@...ts.openwall.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pty: make ptmx file ops read-only after init
On 09/09/2016, 12:35 AM, Kees Cook wrote:
> The ptmx_fops structure is only changed during init, so mark it as such.
Right, but I am missing what is the benefit? You would have to elaborate
here...
> Signed-off-by: Kees Cook <keescook@...omium.org>
> ---
> drivers/tty/pty.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/pty.c b/drivers/tty/pty.c
> index 51e0d32883ba..a23fa5ed1d67 100644
> --- a/drivers/tty/pty.c
> +++ b/drivers/tty/pty.c
> @@ -800,7 +800,7 @@ out_free_file:
> return retval;
> }
>
> -static struct file_operations ptmx_fops;
> +static struct file_operations ptmx_fops __ro_after_init;
>
> static void __init unix98_pty_init(void)
> {
>
thanks,
--
js
suse labs
Download attachment "signature.asc" of type "application/pgp-signature" (826 bytes)
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
