|
Message-ID: <CAGXu5jKEkn5Z2L1UjweSeAxA9RuYL0cdNrRo1J1KCQxD3WG5ZA@mail.gmail.com> Date: Wed, 17 Aug 2016 14:11:28 -0700 From: Kees Cook <keescook@...omium.org> To: Stephen Boyd <sboyd@...eaurora.org>, Syed Rameez Mustafa <rameezmustafa@...eaurora.org> Cc: "Paul E . McKenney" <paulmck@...ux.vnet.ibm.com>, Laura Abbott <labbott@...hat.com>, Steven Rostedt <rostedt@...dmis.org>, Daniel Micay <danielmicay@...il.com>, Joe Perches <joe@...ches.com>, Arnd Bergmann <arnd@...db.de>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Josh Triplett <josh@...htriplett.org>, Mathieu Desnoyers <mathieu.desnoyers@...icios.com>, Lai Jiangshan <jiangshanlai@...il.com>, "Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>, "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>, Michael Ellerman <mpe@...erman.id.au>, Dan Williams <dan.j.williams@...el.com>, Andrew Morton <akpm@...ux-foundation.org>, Ingo Molnar <mingo@...nel.org>, Thomas Gleixner <tglx@...utronix.de>, Josef Bacik <jbacik@...com>, Andrey Ryabinin <aryabinin@...tuozzo.com>, Tejun Heo <tj@...nel.org>, Nikolay Aleksandrov <nikolay@...ulusnetworks.com>, Dmitry Vyukov <dvyukov@...gle.com>, LKML <linux-kernel@...r.kernel.org>, "kernel-hardening@...ts.openwall.com" <kernel-hardening@...ts.openwall.com> Subject: Re: [PATCH v2 0/5] bug: Provide toggle for BUG on data corruption On Wed, Aug 17, 2016 at 1:17 PM, Stephen Boyd <sboyd@...eaurora.org> wrote: > On 08/16, Kees Cook wrote: >> This adds a CONFIG to trigger BUG()s when the kernel encounters >> unexpected data structure integrity as currently detected with >> CONFIG_DEBUG_LIST. >> >> Specifically list operations have been a target for widening flaws to gain >> "write anywhere" primitives for attackers, so this also consolidates the >> debug checking to avoid code and check duplication (e.g. RCU list debug >> was missing a check that got added to regular list debug). It also stops >> manipulations when corruption is detected, since worsening the corruption >> makes no sense. (Really, everyone should build with CONFIG_DEBUG_LIST >> since the checks are so inexpensive.) >> >> This is mostly a refactoring of similar code from PaX and Grsecurity, >> along with MSM kernel changes by Stephen Boyd. > > Which commit in the MSM kernel from me? I wonder if perhaps > you're thinking of a patch from Syed Rameez Mustafa like commit > 1c014f321e6d67f47 in the msm-3.4 kernel. Ooof. I can't read. Yes, you were the committer, not the author! Whoops! https://android.googlesource.com/kernel/msm/+/7b49b86d3aa3d0c6400454a346bad1bbdf0cc78f%5E%21/#F0 I will adjust the changelog. Thanks! -Kees -- Kees Cook Nexus Security
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.