|
Message-ID: <20160803184247.GR4541@io.lakedaemon.net> Date: Wed, 3 Aug 2016 18:42:47 +0000 From: Jason Cooper <jason@...edaemon.net> To: Michael Ellerman <mpe@...erman.id.au> Cc: Kees Cook <keescook@...omium.org>, "Roberts, William C" <william.c.roberts@...el.com>, Yann Droneaud <ydroneaud@...eya.com>, Linux-MM <linux-mm@...ck.org>, LKML <linux-kernel@...r.kernel.org>, "kernel-hardening@...ts.openwall.com" <kernel-hardening@...ts.openwall.com>, Russell King - ARM Linux <linux@....linux.org.uk>, Andrew Morton <akpm@...ux-foundation.org>, Theodore Ts'o <tytso@....edu>, Arnd Bergmann <arnd@...db.de>, Greg KH <gregkh@...uxfoundation.org>, Catalin Marinas <catalin.marinas@....com>, Will Deacon <will.deacon@....com>, Ralf Baechle <ralf@...ux-mips.org>, "benh@...nel.crashing.org" <benh@...nel.crashing.org>, Paul Mackerras <paulus@...ba.org>, "David S. Miller" <davem@...emloft.net>, Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>, "H. Peter Anvin" <hpa@...or.com>, "x86@...nel.org" <x86@...nel.org>, Al Viro <viro@...iv.linux.org.uk>, Nick Kralevich <nnk@...gle.com>, Jeffrey Vander Stoep <jeffv@...gle.com>, Daniel Cashman <dcashman@...roid.com> Subject: Re: Re: [PATCH v2 1/7] random: Simplify API for random address requests On Tue, Aug 02, 2016 at 01:35:13PM +1000, Michael Ellerman wrote: > Jason Cooper <jason@...edaemon.net> writes: > > On Mon, Aug 01, 2016 at 12:47:59PM -0700, Kees Cook wrote: > >> On Sun, Jul 31, 2016 at 1:56 PM, Jason Cooper <jason@...edaemon.net> wrote: > >> > >> I have no new call sites in mind, but it seems safe to add a BUG_ON to > >> verify we don't gain callers that don't follow the correct > >> expectations. (Or maybe WARN and return start.) > > > > No, I think BUG_ON is appropriate. afaict, the only time this will be > > encountered is during the development process. > > Unless it's not. > > Why crash someone's system when you could just page align the value > you're given? Ack, v3 on it's way. thx, Jason.
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.