[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20160629203914.db0dce1f9587a67f1a20a602@gmail.com>
Date: Wed, 29 Jun 2016 20:39:14 +0200
From: Emese Revfy <re.emese@...il.com>
To: Rasmus Villemoes <linux@...musvillemoes.dk>
Cc: kernel-hardening@...ts.openwall.com, pageexec@...email.hu,
spender@...ecurity.net, mmarek@...e.com, keescook@...omium.org,
linux-kernel@...r.kernel.org, yamada.masahiro@...ionext.com,
linux-kbuild@...r.kernel.org, minipli@...linux.so, linux@...linux.org.uk,
catalin.marinas@....com, david.brown@...aro.org, benh@...nel.crashing.org,
tglx@...utronix.de, akpm@...ux-foundation.org, jlayton@...chiereds.net,
arnd@...db.de
Subject: Re: [PATCH v1 2/2] Mark functions with the __nocapture attribute
On Tue, 28 Jun 2016 22:50:55 +0200
Rasmus Villemoes <linux@...musvillemoes.dk> wrote:
> On Tue, Jun 28 2016, Emese Revfy <re.emese@...il.com> wrote:
> > diff --git a/include/asm-generic/bug.h b/include/asm-generic/bug.h
> > index 6f96247..4cdf266 100644
> > --- a/include/asm-generic/bug.h
> > +++ b/include/asm-generic/bug.h
> > @@ -62,13 +62,13 @@ struct bug_entry {
> > * to provide better diagnostics.
> > */
> > #ifndef __WARN_TAINT
> > -extern __printf(3, 4)
> > +extern __printf(3, 4) __nocapture(1, 3, 4)
> > void warn_slowpath_fmt(const char *file, const int line,
> > const char *fmt, ...);
> > -extern __printf(4, 5)
> > +extern __printf(4, 5) __nocapture(1, 4, 5)
> > void warn_slowpath_fmt_taint(const char *file, const int line, unsigned taint,
> > const char *fmt, ...);
>
> The 3,4 and 4,5 parts seem redundant when __printf automatically supplies those.
Thanks, I'll fix them in the next patch set.
--
Emese
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
