Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 28 Jun 2016 17:45:22 +0800
From: Herbert Xu <>
To: David Howells <>
Cc: Andy Lutomirski <>,,,,
	Borislav Petkov <>, Nadav Amit <>,
	Kees Cook <>, Brian Gerst <>,
	"" <>,
	Linus Torvalds <>,
	Josh Poimboeuf <>, Jann Horn <>,
	Heiko Carstens <>
Subject: Re: [PATCH v4 02/29] rxrpc: Avoid using stack memory in SG lists in

On Tue, Jun 28, 2016 at 10:07:44AM +0100, David Howells wrote:
> Since it's (more or less) a one off piece of memory, why not kmalloc it
> temporarily rather than expanding the connection struct?  Also, the bit where
> you put a second rxrpc_crypt in just so that it happens to give you a 16-byte
> slot by adjacency is pretty icky.  It would be much better to use a union
> instead:
> 	union {
> 		struct rxrpc_crypt	csum_iv; /* packet checksum base */
> 		__be32 tmpbuf[4];
> 	};

Feel free to send your own patch to do this.

> Note also that the above doesn't guarantee that the struct will be inside of a
> single page.  It would need an alignment of 16 for that - but you only have
> one sg.  Could that be a problem?

No it's not a problem.
Email: Herbert Xu <>
Home Page:
PGP Key:

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.