kernel-hardening - Re: [PATCH v4 01/29] bluetooth: Switch SMP to crypto_cipher_encrypt

Follow @Openwall on Twitter for new release announcements and other news

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160627085403.GA26865@gmail.com>
Date: Mon, 27 Jun 2016 10:54:03 +0200
From: Ingo Molnar <mingo@...nel.org>
To: Marcel Holtmann <marcel@...tmann.org>
Cc: Andy Lutomirski <luto@...nel.org>, x86@...nel.org,
	LKML <linux-kernel@...r.kernel.org>, linux-arch@...r.kernel.org,
	Borislav Petkov <bp@...en8.de>, Nadav Amit <nadav.amit@...il.com>,
	Kees Cook <keescook@...omium.org>, Brian Gerst <brgerst@...il.com>,
	"kernel-hardening@...ts.openwall.com" <kernel-hardening@...ts.openwall.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Josh Poimboeuf <jpoimboe@...hat.com>, Jann Horn <jann@...jh.net>,
	Heiko Carstens <heiko.carstens@...ibm.com>,
	"Gustavo F. Padovan" <gustavo@...ovan.org>,
	Johan Hedberg <johan.hedberg@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	linux-bluetooth@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH v4 01/29] bluetooth: Switch SMP to
 crypto_cipher_encrypt_one()


* Marcel Holtmann <marcel@...tmann.org> wrote:

> Hi Andy,
> 
> > SMP does ECB crypto on stack buffers.  This is complicated and
> > fragile, and it will not work if the stack is virtually allocated.
> > 
> > Switch to the crypto_cipher interface, which is simpler and safer.
> > 
> > Cc: Marcel Holtmann <marcel@...tmann.org>
> > Cc: Gustavo Padovan <gustavo@...ovan.org>
> > Cc: Johan Hedberg <johan.hedberg@...il.com>
> > Cc: "David S. Miller" <davem@...emloft.net>
> > Cc: linux-bluetooth@...r.kernel.org
> > Cc: netdev@...r.kernel.org
> > Acked-by: Herbert Xu <herbert@...dor.apana.org.au>
> > Acked-and-tested-by: Johan Hedberg <johan.hedberg@...el.com>
> > Signed-off-by: Andy Lutomirski <luto@...nel.org>
> > ---
> > net/bluetooth/smp.c | 67 ++++++++++++++++++++++-------------------------------
> > 1 file changed, 28 insertions(+), 39 deletions(-)
> 
> patch has been applied to bluetooth-next tree.

Sadly carrying this separately will delay the virtual kernel stacks feature by a 
kernel cycle, because it's a must-have prerequisite.

Thanks,

	Ingo

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.