Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 28 Jun 2016 00:30:24 +0200
From: Marcel Holtmann <>
To: Ingo Molnar <>
Cc: Andy Lutomirski <>,,
 LKML <>,,
 Borislav Petkov <>,
 Nadav Amit <>,
 Kees Cook <>,
 Brian Gerst <>,
 "" <>,
 Linus Torvalds <>,
 Josh Poimboeuf <>,
 Jann Horn <>,
 Heiko Carstens <>,
 "Gustavo F. Padovan" <>,
 Johan Hedberg <>,
 "David S. Miller" <>,,
Subject: Re: [PATCH v4 01/29] bluetooth: Switch SMP to crypto_cipher_encrypt_one()

Hi Ingo,

>>> SMP does ECB crypto on stack buffers.  This is complicated and
>>> fragile, and it will not work if the stack is virtually allocated.
>>> Switch to the crypto_cipher interface, which is simpler and safer.
>>> Cc: Marcel Holtmann <>
>>> Cc: Gustavo Padovan <>
>>> Cc: Johan Hedberg <>
>>> Cc: "David S. Miller" <>
>>> Cc:
>>> Cc:
>>> Acked-by: Herbert Xu <>
>>> Acked-and-tested-by: Johan Hedberg <>
>>> Signed-off-by: Andy Lutomirski <>
>>> ---
>>> net/bluetooth/smp.c | 67 ++++++++++++++++++++++-------------------------------
>>> 1 file changed, 28 insertions(+), 39 deletions(-)
>> patch has been applied to bluetooth-next tree.
> Sadly carrying this separately will delay the virtual kernel stacks feature by a 
> kernel cycle, because it's a must-have prerequisite.

I can take it back out, but then I have the fear the the ECDH change to use KPP for SMP might be the one that has to wait a kernel cycle. Either way is fine with me, but I want to avoid nasty merge conflicts in the Bluetooth SMP code.



Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.