kernel-hardening - Re: [PATCH v4 01/29] bluetooth: Switch SMP to crypto_cipher_encrypt

Follow @Openwall on Twitter for new release announcements and other news

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <2833CC26-7306-4803-A5DB-4CBECCF35C08@holtmann.org>
Date: Tue, 28 Jun 2016 00:30:24 +0200
From: Marcel Holtmann <marcel@...tmann.org>
To: Ingo Molnar <mingo@...nel.org>
Cc: Andy Lutomirski <luto@...nel.org>,
 x86@...nel.org,
 LKML <linux-kernel@...r.kernel.org>,
 linux-arch@...r.kernel.org,
 Borislav Petkov <bp@...en8.de>,
 Nadav Amit <nadav.amit@...il.com>,
 Kees Cook <keescook@...omium.org>,
 Brian Gerst <brgerst@...il.com>,
 "kernel-hardening@...ts.openwall.com" <kernel-hardening@...ts.openwall.com>,
 Linus Torvalds <torvalds@...ux-foundation.org>,
 Josh Poimboeuf <jpoimboe@...hat.com>,
 Jann Horn <jann@...jh.net>,
 Heiko Carstens <heiko.carstens@...ibm.com>,
 "Gustavo F. Padovan" <gustavo@...ovan.org>,
 Johan Hedberg <johan.hedberg@...il.com>,
 "David S. Miller" <davem@...emloft.net>,
 linux-bluetooth@...r.kernel.org,
 netdev@...r.kernel.org
Subject: Re: [PATCH v4 01/29] bluetooth: Switch SMP to crypto_cipher_encrypt_one()

Hi Ingo,

>>> SMP does ECB crypto on stack buffers.  This is complicated and
>>> fragile, and it will not work if the stack is virtually allocated.
>>> 
>>> Switch to the crypto_cipher interface, which is simpler and safer.
>>> 
>>> Cc: Marcel Holtmann <marcel@...tmann.org>
>>> Cc: Gustavo Padovan <gustavo@...ovan.org>
>>> Cc: Johan Hedberg <johan.hedberg@...il.com>
>>> Cc: "David S. Miller" <davem@...emloft.net>
>>> Cc: linux-bluetooth@...r.kernel.org
>>> Cc: netdev@...r.kernel.org
>>> Acked-by: Herbert Xu <herbert@...dor.apana.org.au>
>>> Acked-and-tested-by: Johan Hedberg <johan.hedberg@...el.com>
>>> Signed-off-by: Andy Lutomirski <luto@...nel.org>
>>> ---
>>> net/bluetooth/smp.c | 67 ++++++++++++++++++++++-------------------------------
>>> 1 file changed, 28 insertions(+), 39 deletions(-)
>> 
>> patch has been applied to bluetooth-next tree.
> 
> Sadly carrying this separately will delay the virtual kernel stacks feature by a 
> kernel cycle, because it's a must-have prerequisite.

I can take it back out, but then I have the fear the the ECDH change to use KPP for SMP might be the one that has to wait a kernel cycle. Either way is fine with me, but I want to avoid nasty merge conflicts in the Bluetooth SMP code.

Regards

Marcel

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.