|
Message-ID: <CALCETrXz_GHZzx=F3AgQ8FNQ0BJROhnvK5E6-zQd57xpBFAreA@mail.gmail.com> Date: Sun, 26 Jun 2016 09:59:44 -0700 From: Andy Lutomirski <luto@...capital.net> To: Josh Poimboeuf <jpoimboe@...hat.com> Cc: Andy Lutomirski <luto@...nel.org>, X86 ML <x86@...nel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, linux-arch <linux-arch@...r.kernel.org>, Borislav Petkov <bp@...en8.de>, Nadav Amit <nadav.amit@...il.com>, Kees Cook <keescook@...omium.org>, Brian Gerst <brgerst@...il.com>, "kernel-hardening@...ts.openwall.com" <kernel-hardening@...ts.openwall.com>, Linus Torvalds <torvalds@...ux-foundation.org>, Jann Horn <jann@...jh.net>, Heiko Carstens <heiko.carstens@...ibm.com> Subject: Re: [PATCH v4 13/16] x86/dumpstack: Try harder to get a call trace on stack overflow On Fri, Jun 24, 2016 at 8:35 AM, Josh Poimboeuf <jpoimboe@...hat.com> wrote: > On Thu, Jun 23, 2016 at 09:23:08PM -0700, Andy Lutomirski wrote: >> If we overflow the stack, print_context_stack will abort. Detect >> this case and rewind back into the valid part of the stack so that >> we can trace it. >> >> Signed-off-by: Andy Lutomirski <luto@...nel.org> > > Reviewed-by: Josh Poimboeuf <jpoimboe@...hat.com> > FWIW, I'm making a trivial change here for v4: task->stack -> task_stack_page(task). Since it seems inconsequential, I'm keeping your reviewed-by. > -- > Josh -- Andy Lutomirski AMA Capital Management, LLC
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.