kernel-hardening - Re: [PATCH v8 2/4] GCC plugin infrastructure

Follow @Openwall on Twitter for new release announcements and other news

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1463638931.10451.10.camel@ellerman.id.au>
Date: Thu, 19 May 2016 16:22:11 +1000
From: Michael Ellerman <mpe@...erman.id.au>
To: Emese Revfy <re.emese@...il.com>, kernel-hardening@...ts.openwall.com
Cc: Andrew Donnellan <andrew.donnellan@....ibm.com>, 
 linux-kbuild@...r.kernel.org, pageexec@...email.hu, spender@...ecurity.net,
  mmarek@...e.com, keescook@...omium.org, linux@...musvillemoes.dk, 
 fengguang.wu@...el.com, dvyukov@...gle.com, linux-kernel@...r.kernel.org, 
 david.brown@...aro.org, yamada.masahiro@...ionext.com, linuxppc-dev
 <linuxppc-dev@...ts.ozlabs.org>, Daniel Axtens <dja@...ens.net>
Subject: Re: [PATCH v8 2/4] GCC plugin infrastructure

On Wed, 2016-05-18 at 12:33 +0200, Emese Revfy wrote:

> > I've done some basic sanity testing on powerpc with the cyclomatic 
> > complexity plugin (with LE native + cross-compilers) and it seems to 
> > work with the patch below.
> > 
> > Signed-off-by: Andrew Donnellan <andrew.donnellan@....ibm.com>
> > 
> > diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
> > index a18a0dc..0cfed5b 100644
> > --- a/arch/powerpc/Kconfig
> > +++ b/arch/powerpc/Kconfig
> > @@ -97,6 +97,7 @@ config PPC
> >          select HAVE_DYNAMIC_FTRACE_WITH_REGS if MPROFILE_KERNEL
> >          select HAVE_FUNCTION_TRACER
> >          select HAVE_FUNCTION_GRAPH_TRACER
> > +       select HAVE_GCC_PLUGINS
> >          select SYSCTL_EXCEPTION_TRACE
> >          select ARCH_WANT_OPTIONAL_GPIOLIB
> >          select VIRT_TO_BUS if !PPC64
> 
> Hi,
> 
> Did you test the plugins with all gcc versions (4.5-6)?

What's the concern about gcc versions? Just not breaking the build on old
compilers?

I'm pretty sure powerpc big endian still builds with gcc 4.4.

However if Andrew's only tested on little endian, then that select should be
guarded with an "if CPU_LITTLE_ENDIAN". And to build LE you need gcc >= 4.9.

cheers

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.