[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <5728BF03.1050303@linux.intel.com>
Date: Tue, 3 May 2016 08:08:51 -0700
From: Dave Hansen <dave.hansen@...ux.intel.com>
To: Baoquan He <bhe@...hat.com>
Cc: Thomas Garnier <thgarnie@...gle.com>, "H . Peter Anvin" <hpa@...or.com>,
Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>,
Borislav Petkov <bp@...e.de>, Andy Lutomirski <luto@...nel.org>,
Dmitry Vyukov <dvyukov@...gle.com>, Paolo Bonzini <pbonzini@...hat.com>,
Dan Williams <dan.j.williams@...el.com>, Kees Cook <keescook@...omium.org>,
Stephen Smalley <sds@...ho.nsa.gov>, Kefeng Wang
<wangkefeng.wang@...wei.com>, Jonathan Corbet <corbet@....net>,
Matt Fleming <matt@...eblueprint.co.uk>, Toshi Kani <toshi.kani@....com>,
Alexander Kuleshov <kuleshovmail@...il.com>,
Alexander Popov <alpopov@...ecurity.com>, Joerg Roedel <jroedel@...e.de>,
Dave Young <dyoung@...hat.com>, Mark Salter <msalter@...hat.com>,
Boris Ostrovsky <boris.ostrovsky@...cle.com>, x86@...nel.org,
linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org, gthelen@...gle.com,
kernel-hardening@...ts.openwall.com
Subject: Re: [PATCH v2 2/4] x86, boot: PUD VA support for physical mapping
(x86_64)
On 05/03/2016 03:05 AM, Baoquan He wrote:
> I have a tiny concern about phys_pmd_init(), both phys_pud_init and
> phys_pte_init name 2nd parameter as 'addr', phys_pmd_init use 'address'.
> If this can be changed to make them look consistent completist would
> have a good sleep from now on.
Yes, consistency would be nice. Even better would be to call them all
'phys_addr'.
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
