|
Message-ID: <56D75C20.3969.4578E077@pageexec.freemail.hu> Date: Wed, 02 Mar 2016 22:33:20 +0100 From: "PaX Team" <pageexec@...email.hu> To: Emese Revfy <re.emese@...il.com>, Kees Cook <keescook@...omium.org> CC: linux-kbuild <linux-kbuild@...r.kernel.org>, Brad Spengler <spender@...ecurity.net>, "kernel-hardening@...ts.openwall.com" <kernel-hardening@...ts.openwall.com>, Michal Marek <mmarek@...e.com>, Rasmus Villemoes <linux@...musvillemoes.dk>, Fengguang Wu <fengguang.wu@...el.com> Subject: Re: [PATCH v4 1/3] GCC plugin infrastructure On 1 Mar 2016 at 14:50, Kees Cook wrote: > > @@ -124,5 +159,37 @@ quiet_cmd_host-cxxobjs = HOSTCXX $@ > > $(host-cxxobjs): $(obj)/%.o: $(src)/%.cc FORCE > > $(call if_changed_dep,host-cxxobjs) > > > > +# Compile .c file, create position independent .o file > > +# host-cshobjs -> .o > > +quiet_cmd_host-cshobjs = HOSTCC -fPIC $@ > > Is there a reason to include the -fPIC and -shared (below) in the > "quiet" output? this is how it used to be before the entire .so building infrastructure was nuked from the upstream kernel some time last year IIRC, i only kept it alive as it was in PaX. i guess the quiet command was more verbose to make it easier to spot shared objects during make which at the time were built as dependencies only, not as primary targets (as is the case now with the gcc plugins). in any case, this is just a visual clue and i don't particularly care about the color of this bikeshed :).
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.