[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20151217194635.GA23360@kroah.com>
Date: Thu, 17 Dec 2015 11:46:35 -0800
From: Greg KH <gregkh@...uxfoundation.org>
To: kernel-hardening@...ts.openwall.com
Subject: Re: [RFC PATCH v2 01/12] x86: add PAX_REFCOUNT
support
On Thu, Dec 17, 2015 at 01:23:15PM -0500, David Windsor wrote:
> Well, pax_report_refcount_overflow is the mechanism for logging
> overflows and for killing the offending process. Since that's related
> to adding PAX_REFCOUNT protection (not necessarily to just x86,
> though), I put it in this patch. I suppose I could have made another
> patch for arch-independent changes like this.
Yes please, each patch should only do one specific thing. This one
seemed to do many different things, using kconfig options that were not
present yet, making the code useless :)
> You are correct that CONFIG_GRKERNSEC and CONFIG_PAX_REFCOUNT aren't
> currently in the kernel, but they are both added in a later patch in
> this series (patch 11/12). I should have made those changes part of
> this patch, though. I will update the series and resubmit later.
You can introduce the build option first or last, either is fine, but it
was confusing to see this without anything seemingly relevant to the
new atomic type.
thanks,
greg k-h
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
