Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 25 Sep 2013 21:14:37 +0100
From: Djalal Harouni <>
To: "Eric W. Biederman" <>,
	Kees Cook <>,
	Al Viro <>,
	Andrew Morton <>,
	Linus Torvalds <>,
	Ingo Molnar <>,
	"Serge E. Hallyn" <>,
	Cyrill Gorcunov <>,
	LKML <>,,
	Djalal Harouni <>
Subject: [PATCH 04/12] seq_file: Make seq_file able to access the file's opener cred

The f_cred field of the file struct contains the cred of current at
open time. This field can be used to get the context of open, and track
current's cred changes after.

The procfs is one of those fs that need to track current cred changes
in order to implement proper permission checks on each system call.

The procfs make use of seq_file struct and its iterators to step through
/proc objects. These iterators and seq_file helpers must be able to
access the file->f_cred to perform various permission checks at any

Therefor add the f_cred field to the seq_file struct and a helper
seq_f_cred() to return it.

Cc: Kees Cook <>
Cc: Eric W. Biederman <>
Signed-off-by: Djalal Harouni <>
 include/linux/seq_file.h | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/include/linux/seq_file.h b/include/linux/seq_file.h
index 4e32edc..ec07709 100644
--- a/include/linux/seq_file.h
+++ b/include/linux/seq_file.h
@@ -13,6 +13,7 @@ struct file;
 struct path;
 struct inode;
 struct dentry;
+struct cred;
 struct user_namespace;
 struct seq_file {
@@ -26,6 +27,7 @@ struct seq_file {
 	struct mutex lock;
 	const struct seq_operations *op;
 	int poll_event;
+	const struct cred *f_cred;
 	struct user_namespace *user_ns;
@@ -133,6 +135,11 @@ int seq_put_decimal_ull(struct seq_file *m, char delimiter,
 int seq_put_decimal_ll(struct seq_file *m, char delimiter,
 			long long num);
+static inline const struct cred *seq_f_cred(struct seq_file *seq)
+	return seq->f_cred;
 static inline struct user_namespace *seq_user_ns(struct seq_file *seq)

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.