|
Message-ID: <alpine.LFD.2.03.1304090042220.25182@linux-mips.org> Date: Tue, 9 Apr 2013 00:42:49 +0100 (BST) From: "Maciej W. Rozycki" <macro@...ux-mips.org> To: Kees Cook <keescook@...omium.org> cc: Ingo Molnar <mingo@...hat.com>, LKML <linux-kernel@...r.kernel.org>, Thomas Gleixner <tglx@...utronix.de>, "H. Peter Anvin" <hpa@...or.com>, "x86@...nel.org" <x86@...nel.org>, Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>, Jeremy Fitzhardinge <jeremy@...p.org>, Marcelo Tosatti <mtosatti@...hat.com>, Alex Shi <alex.shi@...el.com>, Borislav Petkov <borislav.petkov@....com>, Alexander Duyck <alexander.h.duyck@...el.com>, Frederic Weisbecker <fweisbec@...il.com>, Steven Rostedt <rostedt@...dmis.org>, "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>, "xen-devel@...ts.xensource.com" <xen-devel@...ts.xensource.com>, "virtualization@...ts.linux-foundation.org" <virtualization@...ts.linux-foundation.org>, "kernel-hardening@...ts.openwall.com" <kernel-hardening@...ts.openwall.com>, Dan Rosenberg <drosenberg@...curity.com>, Julien Tinnes <jln@...gle.com>, Will Drewry <wad@...omium.org>, Eric Northup <digitaleric@...gle.com> Subject: Re: [PATCH] x86: make IDT read-only On Mon, 8 Apr 2013, Kees Cook wrote: > > FWIW the change looks reasonable to me, however given that that it makes > > the arrangement unconditional and there is no longer a workaround to > > enable I think it would make sense to remove the conditional block quoted > > above altogether, along with the f00f_workaround_enabled variable itself > > (alternatively "Intel Pentium with F0 0F bug" alone could be printed > > instead and the name of the variable adjusted to make sense with the new > > meaning -- up to you to decide). > > Actually, I take it back. The other portion of the workaround is still > active (in mm/fault.c), and this chunk announces it, so I'm going to > leave it as-is. Ah, OK then. Thanks for double-checking. Maciej
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.