|
Message-ID: <CAGXu5j+6kWpuNudi_43J1coK-fN5NTrev=ycYSmcbr+dFBJMFg@mail.gmail.com> Date: Thu, 12 Apr 2012 15:16:04 -0700 From: Kees Cook <keescook@...omium.org> To: Will Drewry <wad@...omium.org> Cc: linux-kernel@...r.kernel.org, linux-man@...r.kernel.org, linux-security-module@...r.kernel.org, linux-arch@...r.kernel.org, linux-doc@...r.kernel.org, kernel-hardening@...ts.openwall.com, netdev@...r.kernel.org, x86@...nel.org, arnd@...db.de, davem@...emloft.net, hpa@...or.com, mingo@...hat.com, oleg@...hat.com, peterz@...radead.org, rdunlap@...otime.net, mcgrathr@...omium.org, tglx@...utronix.de, luto@....edu, eparis@...hat.com, serge.hallyn@...onical.com, djm@...drot.org, scarybeasts@...il.com, indan@....nu, pmoore@...hat.com, akpm@...ux-foundation.org, corbet@....net, eric.dumazet@...il.com, markus@...omium.org, coreyb@...ux.vnet.ibm.com, jmorris@...ei.org Subject: Re: [PATCH v18 14/15] x86: Enable HAVE_ARCH_SECCOMP_FILTER On Thu, Apr 12, 2012 at 2:48 PM, Will Drewry <wad@...omium.org> wrote: > Enable support for seccomp filter on x86: > - syscall_get_arch() > - syscall_get_arguments() > - syscall_rollback() > - syscall_set_return_value() > - SIGSYS siginfo_t support > - secure_computing is called from a ptrace_event()-safe context > - secure_computing return value is checked (see below). > > SECCOMP_RET_TRACE and SECCOMP_RET_TRAP may result in seccomp needing to > skip a system call without killing the process. This is done by > returning a non-zero (-1) value from secure_computing. This change > makes x86 respect that return value. > > To ensure that minimal kernel code is exposed, a non-zero return value > results in an immediate return to user space (with an invalid syscall > number). > > Signed-off-by: Will Drewry <wad@...omium.org> > Reviewed-by: H. Peter Anvin <hpa@...or.com> > Acked-by: Eric Paris <eparis@...hat.com> Reviewed-by: Kees Cook <keescook@...omium.org> -- Kees Cook ChromeOS Security
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.