Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CA+55aFzKc578eWYaq4+OaOM6hFjW+ePYCeC++_1p8f09YWV_hA@mail.gmail.com>
Date: Sun, 18 Mar 2012 11:25:51 -0700
From: Linus Torvalds <torvalds@...ux-foundation.org>
To: Oleg Nesterov <oleg@...hat.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>, Djalal Harouni <tixxdz@...ndz.org>, 
	Alan Cox <alan@...rguk.ukuu.org.uk>, linux-kernel@...r.kernel.org, 
	kernel-hardening@...ts.openwall.com, Al Viro <viro@...iv.linux.org.uk>, 
	Alexey Dobriyan <adobriyan@...il.com>, "Eric W. Biederman" <ebiederm@...ssion.com>, 
	Vasiliy Kulikov <segoon@...nwall.com>, Kees Cook <keescook@...omium.org>, 
	Solar Designer <solar@...nwall.com>, WANG Cong <xiyou.wangcong@...il.com>, 
	James Morris <james.l.morris@...cle.com>, linux-security-module@...r.kernel.org, 
	linux-fsdevel@...r.kernel.org, Greg KH <gregkh@...uxfoundation.org>, 
	Ingo Molnar <mingo@...e.hu>, Stephen Wilson <wilsons@...rt.ca>, "Jason A. Donenfeld" <Jason@...c4.com>, 
	Roland McGrath <roland@...k.frob.com>
Subject: Re: [PATCH 1/1] CLONE_PARENT shouldn't allow to set ->exit_signal

On Wed, Mar 14, 2012 at 11:55 AM, Oleg Nesterov <oleg@...hat.com> wrote:
> +       if (clone_flags & CLONE_THREAD)
> +               p->exit_signal = -1;
> +       else if (clone_flags & CLONE_PARENT)
> +               p->exit_signal = current->group_leader->exit_signal;
> +       else
> +               p->exit_signal = (clone_flags & CSIGNAL);

So why is it "current->group_leader->exit_signal" rather than the much
more logical (imho) and simpler "current->exit_signal"?

                      Linus

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.