kernel-hardening - Re: [PATCH v15 11/13] ptrace,seccomp: Add PTRACE

Follow @Openwall on Twitter for new release announcements and other news

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABqD9hZ-i-Aa5+7DTmtQ5JU4EAKQfP=HenqgJeFZ2pftQqoUcg@mail.gmail.com>
Date: Thu, 15 Mar 2012 09:40:13 -0500
From: Will Drewry <wad@...omium.org>
To: Indan Zupancic <indan@....nu>
Cc: linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org, 
	linux-doc@...r.kernel.org, kernel-hardening@...ts.openwall.com, 
	netdev@...r.kernel.org, x86@...nel.org, arnd@...db.de, davem@...emloft.net, 
	hpa@...or.com, mingo@...hat.com, oleg@...hat.com, peterz@...radead.org, 
	rdunlap@...otime.net, mcgrathr@...omium.org, tglx@...utronix.de, luto@....edu, 
	eparis@...hat.com, serge.hallyn@...onical.com, djm@...drot.org, 
	scarybeasts@...il.com, pmoore@...hat.com, akpm@...ux-foundation.org, 
	corbet@....net, eric.dumazet@...il.com, markus@...omium.org, 
	coreyb@...ux.vnet.ibm.com, keescook@...omium.org
Subject: Re: [PATCH v15 11/13] ptrace,seccomp: Add PTRACE_SECCOMP support

On Wed, Mar 14, 2012 at 11:49 PM, Indan Zupancic <indan@....nu> wrote:
> Hi Will,
>
> On Thu, March 15, 2012 04:12, Will Drewry wrote:
>> @@ -73,6 +74,7 @@
>>  #define PTRACE_EVENT_VFORK_DONE      5
>>  #define PTRACE_EVENT_EXIT    6
>>  #define PTRACE_EVENT_STOP    7
>> +#define PTRACE_EVENT_SECCOMP 8
>>
>>  #include <asm/ptrace.h>
>>
>> @@ -101,8 +103,9 @@
>>  #define PT_TRACE_EXEC                PT_EVENT_FLAG(PTRACE_EVENT_EXEC)
>>  #define PT_TRACE_VFORK_DONE  PT_EVENT_FLAG(PTRACE_EVENT_VFORK_DONE)
>>  #define PT_TRACE_EXIT                PT_EVENT_FLAG(PTRACE_EVENT_EXIT)
>> +#define PT_TRACE_SECCOMP     PT_EVENT_FLAG(PTRACE_EVENT_SECCOMP)
>>
>> -#define PT_TRACE_MASK        0x000003f4
>> +#define PT_TRACE_MASK        0x00000ff4
>
> Did you miss this bit?

Kinda.  I'll go ahead and switch it to 0xbf4, but PT_TRACE_MASK
doesn't exist in linux-next so this bit disappears on merge.  However,
it is relevant if people are backporting this code, so I'll push a new
rev of it in a bit if I don't get any other comments (or include it in
the next rev if there are comments).

Thanks!
will

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.