|
Message-ID: <CABqD9ha1mMMe09abu7JA+104GfwYwhH4o1Tp-SxGJTmO849D5Q@mail.gmail.com> Date: Wed, 22 Feb 2012 13:48:17 -0600 From: Will Drewry <wad@...omium.org> To: "H. Peter Anvin" <hpa@...or.com> Cc: linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org, linux-doc@...r.kernel.org, kernel-hardening@...ts.openwall.com, netdev@...r.kernel.org, x86@...nel.org, arnd@...db.de, davem@...emloft.net, mingo@...hat.com, oleg@...hat.com, peterz@...radead.org, rdunlap@...otime.net, mcgrathr@...omium.org, tglx@...utronix.de, luto@....edu, eparis@...hat.com, serge.hallyn@...onical.com, djm@...drot.org, scarybeasts@...il.com, indan@....nu, pmoore@...hat.com, akpm@...ux-foundation.org, corbet@....net, eric.dumazet@...il.com, markus@...omium.org, keescook@...omium.org Subject: Re: [PATCH v10 05/11] seccomp: add system call filtering using BPF On Wed, Feb 22, 2012 at 12:32 AM, H. Peter Anvin <hpa@...or.com> wrote: > On 02/21/2012 09:30 AM, Will Drewry wrote: >> + >> +/** >> + * struct seccomp_data - the format the BPF program executes over. >> + * @args: up to 6 system call arguments. When the calling convention is >> + * 32-bit, the arguments will still be at each args[X] offset. >> + * @instruction_pointer: at the time of the system call. >> + * @arch: indicates system call convention as an AUDIT_ARCH_* value >> + * as defined in <linux/audit.h>. >> + * @nr: the system call number >> + */ >> +struct seccomp_data { >> + __u64 args[6]; >> + __u64 instruction_pointer; >> + __u32 arch; >> + int nr; >> +}; >> > > This got flipped around for some reason... that is a problem if we ever > need to extend this to more than 6 arguments (I thought we had at least > one architecture which supported 7 arguments already, but I could just > be delusional.) Makes sense - I'll put it back in the proper order. thanks!
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.