[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAGXu5jJ4enHVmrdsVK-gpE9RpXfjB7+s5+xRci6KQEhTGGed3g@mail.gmail.com>
Date: Wed, 14 Dec 2011 23:06:56 -0800
From: Kees Cook <keescook@...omium.org>
To: Ingo Molnar <mingo@...e.hu>
Cc: linux-kernel@...r.kernel.org, Randy Dunlap <rdunlap@...otime.net>,
Alexander Viro <viro@...iv.linux.org.uk>, Rik van Riel <riel@...hat.com>,
Federica Teodori <federica.teodori@...glemail.com>,
Lucian Adrian Grijincu <lucian.grijincu@...il.com>, Andrew Morton <akpm@...ux-foundation.org>,
Peter Zijlstra <a.p.zijlstra@...llo.nl>, Eric Paris <eparis@...hat.com>,
Dan Rosenberg <drosenberg@...curity.com>, linux-doc@...r.kernel.org,
linux-fsdevel@...r.kernel.org, kernel-hardening@...ts.openwall.com
Subject: Re: [PATCH v2011.2] fs: symlink restrictions on sticky directories
On Wed, Dec 14, 2011 at 10:48 PM, Ingo Molnar <mingo@...e.hu> wrote:
> * Kees Cook <keescook@...omium.org> wrote:
>
>> + ab = audit_log_start(current->audit_context,
>> + GFP_ATOMIC, AUDIT_AVC);
>
> Hm, is GFP_ATOMIC really necessary here? Why not GFP_KERNEL?
> This is in VFS process context, not in some atomic context that
> has to be careful about allocations, right?
Hm, that's true. I had started from the lsm_audit interface, but had
to expand it, and in the process copied its use of audit_log_start().
But yeah, I don't see a reason it can't be GFP_KERNEL. I'll adjust it.
Thanks!
-Kees
--
Kees Cook
ChromeOS Security
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
