![]() |
|
Message-ID: <20111212113618.GB12141@albatros> Date: Mon, 12 Dec 2011 15:36:18 +0400 From: Vasiliy Kulikov <segoon@...nwall.com> To: Andrew Morton <akpm@...ux-foundation.org> Cc: Al Viro <viro@...IV.linux.org.uk>, Alexey Dobriyan <adobriyan@...il.com>, kernel-hardening@...ts.openwall.com, linux-kernel@...r.kernel.org, Hugh Dickins <hughd@...gle.com> Subject: [PATCH v2 -next] proc: fix task_struct memleak proc_pid_permission() doesn't put task_struct on every /proc/$pid/ access. A demo from Hugh Dickins: while :; do ps; grep KernelStack /proc/meminfo; sleep 1; done Reported-by: Hugh Dickins <hughd@...gle.com> Tested-by: Hugh Dickins <hughd@...gle.com> Signed-off-by: Vasiliy Kulikov <segoon@...nwall.com> --- This is a patch against a hidepid patchset from -mm. fs/proc/base.c | 9 +++++++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/fs/proc/base.c b/fs/proc/base.c index 8caf5cb..c2b38bc 100644 --- a/fs/proc/base.c +++ b/fs/proc/base.c @@ -646,9 +646,14 @@ static bool has_pid_permissions(struct pid_namespace *pid, static int proc_pid_permission(struct inode *inode, int mask) { struct pid_namespace *pid = inode->i_sb->s_fs_info; - struct task_struct *task = get_proc_task(inode); + struct task_struct *task; + bool has_perms; + + task = get_proc_task(inode); + has_perms = has_pid_permissions(pid, task, 1); + put_task_struct(task); - if (!has_pid_permissions(pid, task, 1)) { + if (!has_perms) { if (pid->hide_pid == 2) { /* * Let's make getdents(), stat(), and open() -- 1.7.0.4
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.