[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20111211205939.GH2203@ZenIV.linux.org.uk>
Date: Sun, 11 Dec 2011 20:59:39 +0000
From: Al Viro <viro@...IV.linux.org.uk>
To: Vasiliy Kulikov <segoon@...nwall.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
Alexey Dobriyan <adobriyan@...il.com>,
kernel-hardening@...ts.openwall.com, linux-kernel@...r.kernel.org,
Hugh Dickins <hughd@...gle.com>
Subject: Re: [PATCH -next] proc: fix task_struct infoleak
On Sun, Dec 11, 2011 at 10:28:21PM +0400, Vasiliy Kulikov wrote:
> proc_pid_permission() doesn't put task_struct on every /proc/$pid/
> access. A demo from Hugh Dickins:
>
> while :; do ps; grep KernelStack /proc/meminfo; sleep 1; done
>
> Reported-by: Hugh Dickins <hughd@...gle.com>
> Signed-off-by: Vasiliy Kulikov <segoon@...nwall.com>
> ---
> This is a patch against a hidepid patchset from -mm.
Choose saner commit summary, please. It's not information leak, for pity sake
- it's a plain and simple memory leak...
Speaking of which, I've a couple of memory leaks in mainline procfs and
mqueue; Alexey, are you OK with that sucker going directly to Linus or
would you rather push it yourself? See the patch below...
diff --git a/fs/proc/root.c b/fs/proc/root.c
index 9a8a2b7..03102d9 100644
--- a/fs/proc/root.c
+++ b/fs/proc/root.c
@@ -91,20 +91,18 @@ static struct file_system_type proc_fs_type = {
void __init proc_root_init(void)
{
- struct vfsmount *mnt;
int err;
proc_init_inodecache();
err = register_filesystem(&proc_fs_type);
if (err)
return;
- mnt = kern_mount_data(&proc_fs_type, &init_pid_ns);
- if (IS_ERR(mnt)) {
+ err = pid_ns_prepare_proc(&init_pid_ns);
+ if (err) {
unregister_filesystem(&proc_fs_type);
return;
}
- init_pid_ns.proc_mnt = mnt;
proc_symlink("mounts", NULL, "self/mounts");
proc_net_init();
@@ -209,5 +207,5 @@ int pid_ns_prepare_proc(struct pid_namespace *ns)
void pid_ns_release_proc(struct pid_namespace *ns)
{
- mntput(ns->proc_mnt);
+ kern_unmount(ns->proc_mnt);
}
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
