|
Message-ID: <20111119163058.GA3131@albatros> Date: Sat, 19 Nov 2011 20:30:58 +0400 From: Vasiliy Kulikov <segoon@...nwall.com> To: Kees Cook <keescook@...omium.org> Cc: linux-kernel@...r.kernel.org, linux-security-module@...r.kernel.org, kernel-hardening@...ts.openwall.com Subject: Re: [PATCH 3/3] security: Yama: add ptrace relationship tracking interface Hi Kees, Thank you for working on this! We'll use Yama in Openwall too :-) On Wed, Oct 26, 2011 at 16:49 -0700, Kees Cook wrote: > + if (mode == PTRACE_MODE_ATTACH && > + ptrace_scope && > + !capable(CAP_SYS_PTRACE) && > + !task_is_descendant(current, child) && > + !ptracer_exception_found(current, child)) > + rc = -EPERM; capable() is better to put after all other tests as a failed capable() might emit a false positive warning into logs or something. Thanks, -- Vasiliy
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.