[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAM_iQpUAqDmP571R3NkYOmPC7yAEMaHTFmmQCm5hLUXV5Fh8xQ@mail.gmail.com>
Date: Tue, 15 Nov 2011 19:48:15 +0800
From: Américo Wang <xiyou.wangcong@...il.com>
To: Vasiliy Kulikov <segoon@...nwall.com>
Cc: kernel-hardening@...ts.openwall.com,
Andrew Morton <akpm@...ux-foundation.org>, linux-kernel@...r.kernel.org,
Alexey Dobriyan <adobriyan@...il.com>, Al Viro <viro@...iv.linux.org.uk>,
"H. Peter Anvin" <hpa@...or.com>, Greg KH <greg@...ah.com>, Theodore Tso <tytso@....edu>,
Alan Cox <alan@...rguk.ukuu.org.uk>, Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [RFC 1/3] procfs: parse mount options
On Tue, Nov 15, 2011 at 7:21 PM, Vasiliy Kulikov <segoon@...nwall.com> wrote:
> +
> +static int proc_parse_options(char *options, struct pid_namespace *pid)
> +{
> + char *p;
> + substring_t args[MAX_OPT_ARGS];
> + int option;
'option' is unused?
> +
> + pr_debug("proc: options = %s\n", options);
> +
> + if (!options)
> + return 1;
> +
> + while ((p = strsep(&options, ",")) != NULL) {
> + int token;
> + if (!*p)
> + continue;
> +
> + args[0].to = args[0].from = 0;
> + token = match_token(p, tokens, args);
> + switch (token) {
> + default:
This switch block reads odd...
> + pr_err("proc: unrecognized mount option \"%s\" "
> + "or missing value", p);
"\n" is needed.
> + return 0;
> + }
> + }
> +
> + return 1;
> +}
Regards.
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
