kernel-hardening - Re: [PATCH] acpi: constify ops structs

Follow @Openwall on Twitter for new release announcements and other news

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110715063526.GB3166@albatros>
Date: Fri, 15 Jul 2011 10:35:26 +0400
From: Vasiliy Kulikov <segoon@...nwall.com>
To: Len Brown <lenb@...nel.org>
Cc: kernel-hardening@...ts.openwall.com, Shaohua Li <shaohua.li@...el.com>,
	Zhang Rui <rui.zhang@...el.com>, Jeff Garzik <jgarzik@...ox.com>,
	Jesse Barnes <jbarnes@...tuousgeek.org>, linux-acpi@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-ide@...r.kernel.org,
	linux-pci@...r.kernel.org
Subject: Re: [PATCH] acpi: constify ops structs

Hi Len,

On Sat, Jun 25, 2011 at 21:07 +0400, Vasiliy Kulikov wrote:
> Structs battery_file, acpi_dock_ops, file_operations,
> thermal_cooling_device_ops, thermal_zone_device_ops, kernel_param_ops
> are not changed in runtime.  It is safe to make them const.
> register_hotplug_dock_device() was altered to take const "ops" argument
> to respect acpi_dock_ops' const notion.
> 
> Signed-off-by: Vasiliy Kulikov <segoon@...nwall.com>
> ---

Any problems with the patch?

>  Len, I think it can be applied as a single patch to acpi tree as the
>  only non-acpi thing is acpi_dock_ops in ata/ and pci/, which is really
>  trivial.

Thanks,

-- 
Vasiliy Kulikov
http://www.openwall.com - bringing security into open computing environments

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.