Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1308760683.10423.16.camel@Joe-Laptop>
Date: Wed, 22 Jun 2011 09:38:03 -0700
From: Joe Perches <joe@...ches.com>
To: Vasiliy Kulikov <segoon@...nwall.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>, James Morris
 <jmorris@...ei.org>,  Ingo Molnar <mingo@...e.hu>, Namhyung Kim
 <namhyung@...il.com>, Greg Kroah-Hartman <gregkh@...e.de>, 
 kernel-hardening@...ts.openwall.com, linux-kernel@...r.kernel.org, 
 security@...nel.org
Subject: Re: [PATCH] kernel: escape non-ASCII and control characters in
 printk()

On Wed, 2011-06-22 at 13:53 +0400, Vasiliy Kulikov wrote:
> This patch escapes all characters outside of allowed '\n' plus 0x20-0x7E
> charset passed to printk().

[]

> diff --git a/kernel/printk.c b/kernel/printk.c
[]
> +static void emit_log_char_escaped(char c)
> +{
> +	char buffer[8];
> +	int i, len;
> +
> +	if ((c >= ' ' && c < 127) || c == '\n')

	if (isprint(c))

Why not add this to emit_log_char?


Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.