[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4DC49FF4.6020604@bredband.net>
Date: Sat, 07 May 2011 03:27:16 +0200
From: magnum <rawsmooth@...dband.net>
To: john-users@...ts.openwall.com
Subject: Re: Plumbing changes
On 2011-05-07 03:06, JimF wrote:
> That sounds like a wonderful addition.
>
> However, somewhere, there still will likely be a spot with major patch
> clashes. load formats is one of them. Every new format has to be
> declared at 'some' point. One possible work around here, would be
> special include files or something where each developer got his own.
I think if we come to the point where it's just one line in Makefile and
two in john.c, we should get along just fine as-is [for new formats] as
long as people choose good points of inserting new lines. For example,
Dhiru's three patches all add their lines in the exact same spot (no
offense, just sayin'). If he had put the SybaseASE line very high in the
list (as it was the first patch since Jumbo), the ssh line at least four
lines down from that, and the rar line four lines down again, the pathes
would not clash.
If he had done it that way, and I wrote a new format, I'd just put my
lines four lines below the rar line. The only thing needed is having a
look at the formats already posted but not included in Jumbo.
BTW thanks a lot for the new md5-gen patch, I'll have a good long look
at it.
magnum
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
