[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4D6D451F.10609@bredband.net>
Date: Tue, 01 Mar 2011 20:12:31 +0100
From: magnum <rawsmooth@...dband.net>
To: john-users@...ts.openwall.com
Subject: Re: MD5 Generic improvements
On 03/01/2011 05:04 PM, bartavelle wrote:
> This doesn't seem to work for me :
> Loaded 1593941 password hashes with 42272 different salts ( md5_gen(0):
> md5($p) (raw-md5) [128x1 (MD5_Go)])
>
Reverting to what Jim wrote in
http://www.openwall.com/lists/john-users/2011/02/26/2 fixes the problem:
> This change is to md5_gen_fmt.c in the get_salt function:
>
> static void *get_salt(char *ciphertext)
> {
> static char Salt[SALT_SIZE+1];
> memset(Salt, 0, SALT_SIZE+1);
> + if (saltlen==0)
> + return Salt;
> strncpy(Salt, &ciphertext[md5_gen_SALT_OFFSET], SALT_SIZE);
> Salt[SALT_SIZE] = 0;
> if (md5_gen_salt_as_hex)
But then in the early-release-02 it was changed to
if (fmt_MD5gen.params.salt_size==0)
I just tried both (no idea if that makes sense) and it works fine:
if (fmt_MD5gen.params.salt_size==0 || saltlen==0)
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
